Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using boolean as message parameters does not work as expected #20

Closed
kaklakariada opened this issue Mar 24, 2022 · 0 comments · Fixed by #21
Closed

Using boolean as message parameters does not work as expected #20

kaklakariada opened this issue Mar 24, 2022 · 0 comments · Fixed by #21
Assignees
Labels
bug Unwanted / harmful behavior

Comments

@kaklakariada
Copy link
Collaborator

kaklakariada commented Mar 24, 2022

Booleans

Boolean values throw an error: Error: /Users/user/git/error-reporting-lua/src/message_expander.lua:62: invalid value (boolean) at index 8 in table for 'concat'

function test_message_expander.test_expand_boolean_parameter()
    assertMessageWithParametersRendersTo("before {{value}} after", {value = true},
        "before 'true' after")
end
@kaklakariada kaklakariada added the bug Unwanted / harmful behavior label Mar 24, 2022
@kaklakariada kaklakariada self-assigned this May 13, 2022
@kaklakariada kaklakariada changed the title Using boolean and tables as message parameters does not work as expected Using boolean as message parameters does not work as expected May 13, 2022
kaklakariada added a commit that referenced this issue May 13, 2022
* #20: Fix using boolean message parameters

* Allow running script under macOS

* Fix ticket link in previous changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unwanted / harmful behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant