Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support self hosted git repo #139

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Support self hosted git repo #139

merged 1 commit into from
Aug 9, 2024

Conversation

dzuev2
Copy link
Contributor

@dzuev2 dzuev2 commented Aug 8, 2024

Closes #138

Checklist:

  • Tests
  • Documentation

@dzuev2 dzuev2 requested a review from ewjoachim as a code owner August 8, 2024 21:08
Copy link
Owner

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me. Congratulations for you first contribution, and happy that the PR went smoothly :)

Comment on lines +204 to +214
def test_extract_releases_custom_graphql_url(github_payload, release_dict, mocker):
mocker.patch(
"sphinx_github_changelog.changelog.github_call", return_value=github_payload
)
assert changelog.extract_releases(
owner_repo="a/b",
token="token",
graphql_url="https://git.privaterepo.com/graphql",
) == [
release_dict,
]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(We're not exactly testing that the graphql_url is used, but it could be good enough)

@ewjoachim ewjoachim merged commit 72a564a into ewjoachim:main Aug 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding support of GitHub Enterprise self-hosted Server
2 participants