Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return values print (#63) #76

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

mcflugen
Copy link
Contributor

@ewels What do you think of this as a fix to #63?

I think you probably want to run super().main (in RichCommand.main) with standalone_mode=False so that click doesn't exit or print error message. However, once BaseCommand.main has run and you have the return value, you don't need to pass it on unless RichCommand.main itself was called with standalone_mode set to False.

Copy link
Owner

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab, looks great - thanks!

@ewels ewels merged commit 496547c into ewels:main Jun 21, 2022
@mcflugen mcflugen mentioned this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants