Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix group #104

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Fix group #104

merged 3 commits into from
Apr 12, 2023

Conversation

davidbrochart
Copy link
Contributor

No description provided.

@davidbrochart davidbrochart mentioned this pull request Mar 28, 2023
Merged
@ewels ewels mentioned this pull request Apr 4, 2023
Closed
ewels
ewels approved these changes Apr 12, 2023
View reviewed changes
Copy link
Owner

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not sure either, but I will merge and test 😁

@ewels
Copy link
Owner

ewels commented Apr 12, 2023

Failing test seems to be due to a rich update (was working locally until I tried upgrading)

@ewels ewels merged commit 052e30b into ewels:pullrequest-92 Apr 12, 2023
@davidbrochart davidbrochart deleted the pullrequest-92 branch April 12, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbrochart @ewels