Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dependency-track] Dependency track image pull secrets are incompatible with Postgres subchart #183

Open
ChocPanda opened this issue Aug 25, 2022 · 0 comments · May be fixed by #191
Open

Comments

@ChocPanda
Copy link

ChocPanda commented Aug 25, 2022

Describe the bug

When configuring image pull secrets when using private docker repositories for both postgres and dependency track the charts require different format image pull secrets and dependency track only reads them from global

The dependency track chart expects image pull secrets in the values:

global:
  imagePullSecrets:
    - name: regcred

The postgres chart expects image pull secrets in the values:

global:
  imagePullSecrets:
    - regcred

Version of Helm and Kubernetes:

Which chart:

Dependency Track

How to reproduce it (as minimally and precisely as possible):

Using values

global:
  imageRegistry: private-repo/repo
  imagePullSecrets:
    - name: regcred

What happened:

 # Source: dependency-track/charts/dependency-track/templates/backend/deployment.yaml
 apiVersion: apps/v1
 kind: Deployment
@@ -187,6 +251,8 @@
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/component: backend
     spec:
+      imagePullSecrets:
+      - name: regcred
 ---
+# Source: dependency-track/charts/postgresql/templates/statefulset.yaml
+apiVersion: apps/v1
+kind: StatefulSet
+    spec:      
+      imagePullSecrets:
+        - name: map[name:regcred]

What you expected to happen:

 # Source: dependency-track/charts/dependency-track/templates/backend/deployment.yaml
 apiVersion: apps/v1
 kind: Deployment
@@ -187,6 +251,8 @@
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/component: backend
     spec:
+      imagePullSecrets:
+      - name: regcred
 ---
+# Source: dependency-track/charts/postgresql/templates/statefulset.yaml
+apiVersion: apps/v1
+kind: StatefulSet
+    spec:      
+      imagePullSecrets:
+      - name: regcred

Anything else we need to know:

Rather than using global values for the image pull secrets could you add .Values.imagePullSecrets value to the dependency track chart and default to the global value if it's null

ChocPanda pushed a commit to ChocPanda/helm-charts that referenced this issue Oct 10, 2022
…crets

conflict between postgres and dependency track image pull secrets mean you can't use private repositories for both postgres and dependency track images. this standardises to bitnami approach

BREAKING CHANGE: re: evryfs#183

Signed-off-by: Matt Searle <matthewsearle@improbable.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant