Registration tokens can become stale. (#224)

evryfs · Apr 6, 2021 · 5d83b94 · 5d83b94
1 parent b9bf07a
commit 5d83b94
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/controllers/githubactionrunner_controller.go b/controllers/githubactionrunner_controller.go
@@ -226,7 +226,8 @@ func (r *GithubActionRunnerReconciler) createOrUpdateRegistrationTokenSecret(ctx
 		return err
 	}
 
-	expired := time.Unix(epoch, 0).Before(time.Now().Add(-5 * time.Minute))
+	// allow for 5 minute clock-skew
+	expired := time.Now().Add(5 * time.Minute).After(time.Unix(epoch, 0))
 	if expired {
 		logger.Info("Registration token expired, updating")
 		return r.updateRegistrationToken(ctx, instance, secret)