Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: intrarelayer changes from spec #82

Merged
merged 111 commits into from
Nov 17, 2021
Merged

feat: intrarelayer changes from spec #82

merged 111 commits into from
Nov 17, 2021

Conversation

ramacarlucho
Copy link
Contributor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

fedekunze and others added 30 commits October 18, 2021 13:23
* Validate genesis fix. genesis and params tests

* initial structure for msg and proposal tests

* testing: proposal tests addeds

* testing: update token pair erc20 with invalid addresses

* token pair and msgs test

Co-authored-by: ramacarlucho <ramirocarlucho@gmail.com>
* merge irms branchs

* Fix pack method

* removed valid test from TestRegisterTokenPair, this should be tested on TestRegisterTokenPairWithContract

* using ethermint CompiledContract

* removed unused import

* unpacking using interfaces

* Update x/intrarelayer/types/contracts/erc20.go

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* moved evm types to types folder

* feemarket enabled by default on test suite

* contracts function and test setup moved to keeper_test

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #82 (3402b13) into main (56136d2) will increase coverage by 11.93%.
The diff coverage is 82.35%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #82       +/-   ##
===========================================
+ Coverage   62.53%   74.47%   +11.93%     
===========================================
  Files           4       22       +18     
  Lines         638     1610      +972     
===========================================
+ Hits          399     1199      +800     
- Misses        228      354      +126     
- Partials       11       57       +46     
Impacted Files Coverage Δ
x/intrarelayer/types/codec.go 0.00% <0.00%> (ø)
x/intrarelayer/keeper/evm_hooks.go 47.94% <47.94%> (ø)
x/intrarelayer/keeper/grpc_query.go 71.15% <71.15%> (ø)
x/intrarelayer/keeper/evm.go 72.36% <72.36%> (ø)
x/intrarelayer/keeper/mint.go 77.77% <77.77%> (ø)
x/intrarelayer/keeper/msg_server.go 79.21% <79.21%> (ø)
x/intrarelayer/keeper/gov_hooks.go 81.13% <81.13%> (ø)
x/intrarelayer/keeper/proposals.go 84.90% <84.90%> (ø)
x/intrarelayer/keeper/keeper.go 87.50% <87.50%> (ø)
x/intrarelayer/types/proposal.go 95.00% <95.00%> (ø)
... and 9 more

@fedekunze fedekunze marked this pull request as ready for review November 16, 2021 17:00
@lgtm-com
Copy link

lgtm-com bot commented Nov 16, 2021

This pull request introduces 1 alert when merging ed8f3d7 into 6003aca - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work guys!

@fedekunze fedekunze merged commit 62b8f10 into main Nov 17, 2021
@fedekunze fedekunze deleted the rama/refactor branch November 17, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants