Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

change default maxGasWanted #1208

Merged
merged 4 commits into from
Jul 28, 2022
Merged

change default maxGasWanted #1208

merged 4 commits into from
Jul 28, 2022

Conversation

facs95
Copy link
Contributor

@facs95 facs95 commented Jul 28, 2022

Closes: #XXX

Description

Set DefaultMaxGasWanted to 0 .


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #1208 (31951b4) into main (3460cba) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 31951b4 differs from pull request most recent head f481672. Consider uploading reports for the commit f481672 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
+ Coverage   55.29%   55.31%   +0.01%     
==========================================
  Files          94       94              
  Lines        8391     8376      -15     
==========================================
- Hits         4640     4633       -7     
+ Misses       3517     3508       -9     
- Partials      234      235       +1     
Impacted Files Coverage Δ
app/ante/eth.go 79.61% <0.00%> (-1.93%) ⬇️
server/config/config.go 21.81% <ø> (ø)
x/evm/types/utils.go 60.37% <0.00%> (-2.13%) ⬇️
app/app.go 84.79% <0.00%> (-1.18%) ⬇️
app/ante/handler_options.go 79.45% <0.00%> (-0.55%) ⬇️
app/export.go 12.92% <0.00%> (-0.46%) ⬇️
x/evm/types/codec.go 83.78% <0.00%> (-0.43%) ⬇️
app/utils.go 69.13% <0.00%> (-0.19%) ⬇️
types/int.go 41.66% <0.00%> (ø)
... and 22 more

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! can you add a changelog entry

@fedekunze fedekunze enabled auto-merge (squash) July 28, 2022 19:09
@fedekunze fedekunze merged commit ebbffc6 into evmos:main Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants