Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix!: Fix eth tx hashes in json-rpc responses #1176

Merged
merged 12 commits into from
Jul 19, 2022
Merged

fix!: Fix eth tx hashes in json-rpc responses #1176

merged 12 commits into from
Jul 19, 2022

Commits on Jul 14, 2022

  1. Fix eth tx hashes in json-rpc responses 

    Closes: evmos#1175

- Remove Size_ field
- Validate From/Hash fields in ante handler
- Recompute tx hashes in json-rpc apis to cope with old blocks

Update CHANGELOG.md

remove Size_, validate Hash/From, add unit tests

update spec

Update CHANGELOG.md

Update app/ante/eth.go

populate From in SendRawTransaction

Apply suggestions from code review

keep Size_ field to avoid breaking tx format
    @yihuang
    yihuang committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    922a609 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. move some validation to ValidateBasic

    @yihuang
    yihuang committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    c8deef5 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. move validation to ValidateBasic

    @yihuang
    yihuang committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    b533467 View commit details
    Browse the repository at this point in the history

  2. make ToTransaction returns a valid msg

    @yihuang
    yihuang committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    7220aa7 View commit details
    Browse the repository at this point in the history

  3. restructure the protoTxProvider check

    @yihuang
    yihuang committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    72158ac View commit details
    Browse the repository at this point in the history

  4. add comment

    @yihuang
    yihuang committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    fe67ed1 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into fix-tx-hash

    @yihuang
    yihuang committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    5ff83ed View commit details
    Browse the repository at this point in the history

  6. workaround tx hash issue in event parsing

    @yihuang
    yihuang committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    c6bf219 View commit details
    Browse the repository at this point in the history

  7. fix integration test

    @yihuang
    yihuang committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    7d6a59e View commit details
    Browse the repository at this point in the history

  8. fix unit test

    @yihuang
    yihuang committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    b056db9 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into fix-tx-hash

    @fedekunze
    fedekunze committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    479a812 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into fix-tx-hash

    @fedekunze
    fedekunze committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    2acc2fb View commit details
    Browse the repository at this point in the history