Add reset state actions to our stores. #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerrad
force-pushed
the
FET/reset-state-action
branch
from
b0308c1
to
d160e3d
Compare
nerrad
force-pushed
the
FET/reset-state-action
branch
from
155d6b0
to
ecb625f
Compare
tn3rb
previously approved these changes
Mar 11, 2019
There was a problem hiding this comment.
found one super minor grammer mistake in a comment, and had one suggestion regarding naming.
everything else looks good, but I can't claim to really understand what's going on.
going to approve this, but feel free to pass back for further review if you change any code
- for RESET_ALL_STATE - for RESET_ALL_STATE_FOR_MODEL
nerrad
force-pushed
the
FET/reset-state-action
branch
from
ecb625f
to
88f8bd6
Compare
eeteamcodebase
pushed a commit
that referenced
this pull request
Mar 12, 2019
… state actions to our stores. (#998) ## Problem this Pull Request solves While working on the demo app (#988) and the Barcode Scanner app (eventespresso/eea-barcode-scanner#7) I realized that there will be need for some sort of reset state action for our stores that allows dispatches to restore state to its default shape. For instance with the barcode scanner app the user might scan a new registration for checkin that we'll want to reset all the tracked related registrations etc in the state. Note: a [pull I did for GB](WordPress/gutenberg#14225) recently that adds more sledgehammer like control over the resolution cache in the `core/data` store. It will make it easier for resetting that state in this pull. The downside is it will be tied to a version of WordPress so I can only use it IF the functions exist. "
|
@tn3rb I implemented your suggestions but then decided to go ahead and merge this (after verifying js tests passed) because the changes don't really need reviewed again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem this Pull Request solves
While working on the demo app (#988) and the Barcode Scanner app (eventespresso/eea-barcode-scanner#7) I realized that there will be need for some sort of reset state action for our stores that allows dispatches to restore state to its default shape. For instance with the barcode scanner app the user might scan a new registration for checkin that we'll want to reset all the tracked related registrations etc in the state.
Note: a pull I did for GB recently that adds more sledgehammer like control over the resolution cache in the
core/datastore. It will make it easier for resetting that state in this pull. The downside is it will be tied to a version of WordPress so I can only use it IF the functions exist.How has this been tested
Checklist
esc_html__(), see https://codex.wordpress.org/I18n_for_WordPress_Developers)