Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow psr container v2 #36

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

arnedesmedt
Copy link
Contributor

No description provided.

composer.json Outdated
@@ -1,5 +1,5 @@
{
"name": "event-engine/php-engine",
"name": "arnedesmedt/php-engine",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor name should stay event-engine 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx to look to these MR's!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for another long delay 🙈 . As usual, too much topics going on at the same time with Cody Engine being the most important open source project for me at the moment.

@arnedesmedt I've created a "Core Maintainers" team and invited you. If you want to be able merge PRs yourself, just accept the invitation ;) I trust you to not break the entire functionality of Event Engine ;)

If you like the idea, I'd give the team also access to other event engine packages. Let me know what you think about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @codeliner I can imagine that maintaining open source projects besides your other work is not that easy :-)
So I think your solution of creating a team is a good one! Thx to add me and be aware that your work is much appreciated!

@codeliner codeliner merged commit 706c9db into event-engine:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants