Ocpp: deduplicate event handlers #16278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ich verstehe was du meinst, dennoch sind dies tatsächlich alles CP-Events: 
|
|
Das ist klar. Wir haben aber eigentlich keinen Grund, die auch im Code am CP zu handeln. Stell dir das einfach als das catch-all vor nachdem kein passender CP gefunden wurde. |
premultiply
reviewed
Sep 23, 2024
|
Ja, verstehe ich, dennoch sind das eigentlich CP-Aktionen. Dann sollten wir das im CS zumindest entsprechend kommentieren, dass hier nur die Abkürzung genommen wird, da nicht weiter im CP verarbeitet. |
Stell dir das einfach vor wie die anderen Handler auch- nur das hier vorher keine CP-spezifischen Aufrufe mehr getätigt werden. So als würde es keinen handlenden CP geben. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all cp event handlers to cs where logic is globally handled