Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocpp: provide better support multiple connectors #15762

Merged
merged 13 commits into from
Sep 1, 2024
Merged

Conversation

andig
Copy link
Member

@andig andig commented Aug 28, 2024

Fix #15559, fix #15677

This PR moves setup procedure from charger (where is is implemented pre connector) to chargepoint where possible. Chargepoints are only initialised once. This should help with various startup/timeout errors.

@andig andig added enhancement New feature or request devices Specific device support labels Aug 28, 2024
charger/ocpp/cp_setup.go Outdated Show resolved Hide resolved
charger/ocpp.go Show resolved Hide resolved
charger/ocpp/cp_setup.go Outdated Show resolved Hide resolved
charger/ocpp.go Show resolved Hide resolved
@premultiply
Copy link
Member

premultiply commented Aug 30, 2024

Wir sollten besser noch

	if c.conn.NeedsAuthentication() {
		if c.remoteStart {
			// lock the cable by starting remote transaction after vehicle connected
			if err := c.initTransaction(); err != nil {
				c.log.WARN.Printf("failed to start remote transaction: %v", err)
			}
		} else {
			// TODO: bring this status to UI
			c.log.WARN.Printf("waiting for local authentication")
		}
	}

vom synchronen Charger-Status an den asynchronen StatusNotification-Handler des Connectors verschieben.

Sonst gibt es Timeout-Probleme wenn das interval zu groß für das ConnectTimeout (also das interne Authentication-Timeout der Box) ist. Sichtbar z.B. hier #15752.

Dabei kann die Warning auch zu einer einfachen Debug-Message werden.

Kann man natürlich auch noch separat im Anschluss machen, passt aber thematisch eigentlich hier hinein.

@andig
Copy link
Member Author

andig commented Aug 30, 2024

Gerne, aber das ist ein separates Thema!

@andig
Copy link
Member Author

andig commented Aug 30, 2024

@premultiply ok von Deiner Seite?

@premultiply
Copy link
Member

Ich würde es nachher noch real testen.

charger/ocpp/cp.go Outdated Show resolved Hide resolved
@andig andig merged commit 71f58e9 into master Sep 1, 2024
6 checks passed
@andig andig deleted the feat/ocpp-cp-centered branch September 1, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devices Specific device support enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCPP: Mennekes Smart Charging Station seit 0.130.0 Fehlerhaft ABL eMH3: OCPP setup issues
2 participants