Skip to content

Commit

Permalink
prevent screen from juddering when clicking on diagram (#15815)
Browse files Browse the repository at this point in the history
  • Loading branch information
Maschga authored Sep 5, 2024
1 parent f5b6bb2 commit c35eaca
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 9 deletions.
4 changes: 4 additions & 0 deletions assets/css/app.css
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,10 @@ body {
color: var(--evcc-default-text);
}

body:not(.modal-open) {
overflow-y: scroll;
}

h1,
h2,
h3,
Expand Down
2 changes: 0 additions & 2 deletions assets/js/components/Footer.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,3 @@ export default {
},
};
</script>

<style scoped></style>
16 changes: 9 additions & 7 deletions assets/js/components/Version.vue
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
<template>
<div>
<div class="text-truncate">
<a
v-if="commit"
:href="githubHashUrl"
target="_blank"
class="btn btn-link ps-0 text-decoration-none evcc-default-text text-nowrap d-flex align-items-end"
>
<Logo class="logo me-2" />
<span class="text-decoration-underline">v{{ installed }}</span>
<shopicon-regular-moonstars class="ms-2 text-gray-light"></shopicon-regular-moonstars>
<Logo class="logo me-2 flex-shrink-0" />
<span class="text-decoration-underline text-truncate">v{{ installed }}</span>
<shopicon-regular-moonstars
class="ms-2 text-gray-light flex-shrink-0"
></shopicon-regular-moonstars>
</a>
<button
v-else-if="newVersionAvailable"
Expand All @@ -17,7 +19,7 @@
@click="openModal"
>
<shopicon-regular-gift class="me-2"></shopicon-regular-gift>
<span class="text-decoration-underline">v{{ installed }}</span>
<span class="text-decoration-underline text-truncate">v{{ installed }}</span>
<span class="ms-2 d-none d-sm-block text-gray-medium text-decoration-underline">
{{ $t("footer.version.availableLong") }}
</span>
Expand All @@ -28,8 +30,8 @@
target="_blank"
class="btn btn-link evcc-default-text ps-0 text-decoration-none text-nowrap d-flex align-items-end"
>
<Logo class="logo me-2" />
<span class="text-decoration-underline">v{{ installed }}</span>
<Logo class="logo me-2 flex-shrink-0" />
<span class="text-decoration-underline text-truncate">v{{ installed }}</span>
</a>

<Teleport to="body">
Expand Down

0 comments on commit c35eaca

Please sign in to comment.