Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fetch API types as accepted mock parameters #291

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

mhaligowski
Copy link
Contributor

@mhaligowski mhaligowski commented Jan 7, 2024

Adds Fetch API's Request and Response objects to accepted generic types, allowing for using objects that extend this, e.g. NextJS App Router.

fixes #233

Copy link

Stale pull request message

@github-actions github-actions bot closed this Mar 24, 2024
@eugef eugef reopened this Mar 25, 2024
@github-actions github-actions bot closed this Apr 2, 2024
@eugef eugef reopened this Apr 2, 2024
@mhaligowski
Copy link
Contributor Author

@eugef what's up with this? I guess I need to update the branch, right?

@eugef
Copy link
Owner

eugef commented Apr 3, 2024

Hi @mhaligowski

If you can run npm run format and commit the changes then I would be able to merge this PR

Copy link

Stale pull request message

@eugef
Copy link
Owner

eugef commented Aug 28, 2024

Hi @mhaligowski

Can you please run npm run format and commit the changes

@mhaligowski
Copy link
Contributor Author

@eugef sorry, on it!

@eugef eugef merged commit 845ca93 into eugef:master Sep 9, 2024
3 checks passed
@eugef
Copy link
Owner

eugef commented Sep 9, 2024

@mhaligowski no problem, thanks for updating PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript: Type 'string' is not assignable to type 'Body | undefined'
2 participants