Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing capability in TypeScript #282

Merged
merged 7 commits into from
Nov 30, 2023

Conversation

mhaligowski
Copy link
Contributor

This PR is a preparatory work for a solution for #280.

Adds capability of implementing mocha unit tests with TypeScript, and adds one sample test to make sure that it's working as expected. The tests are ran separately, with test:ts and spec:ts gulp commands, until they can be safely merged in to full testing and CI pipeline.

This PR DOES NOT enforce ESLint rules for TypeScript tests, since it's failing on the versions mismatches,

@mhaligowski mhaligowski marked this pull request as ready for review November 24, 2023 21:28
Copy link
Owner

@eugef eugef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eugef eugef mentioned this pull request Nov 27, 2023
@mhaligowski
Copy link
Contributor Author

@eugef is there anything else for me to do with this PR?

@eugef
Copy link
Owner

eugef commented Nov 29, 2023

Just let me know in what order do you want PRs to be merged.
First this one and then #281 ?

@mhaligowski
Copy link
Contributor Author

Yeah, let's merge this one first, I'll rebase #281 and add some unit tests there.

@eugef eugef merged commit 79e42b2 into eugef:master Nov 30, 2023
3 checks passed
@eugef
Copy link
Owner

eugef commented Nov 30, 2023

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants