This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Fixing inconsistent SaaS connector integration tests #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entry Updating Stripe access test
PSalant726
reviewed
May 6, 2022
PSalant726
suggested changes
May 6, 2022
seanpreston
reviewed
May 7, 2022
| @@ -137,8 +137,9 @@ def hubspot_erasure_data(connection_config_hubspot, hubspot_erasure_identity_ema | |||
| # no need to subscribe contact, since creating a contact auto-subscribes them | |||
|
|
|||
| # Allows contact to be propagated in Hubspot before calling access / erasure requests | |||
| remaining_tries = 5 | |||
| remaining_tries = 10 | |||
There was a problem hiding this comment.
I wonder if we could encapsulate these things in config vars specific to these tests so they can be tuned easier. Do we have a clear picture of how long a contact takes to propagate through Hubspot, or does it vary?
There was a problem hiding this comment.
It varies but this is a good future proposal to have the configuration in one place
|
Thanks @galvana these changes are super useful |
6 tasks
PSalant726
suggested changes
May 9, 2022
galvana
added
run unsafe ci checks
PSalant726
approved these changes
May 10, 2022
…h-saas-connector-integration-tests
galvana
added
run unsafe ci checks
galvana
added
run unsafe ci checks
galvana
added
run unsafe ci checks
galvana
deleted the
472-saas-connectors-inconsistent-results-with-saas-connector-integration-tests
branch
adamsachs
pushed a commit
to adamsachs/fidesops_forked_test
that referenced
this pull request
May 17, 2022
Fixing inconsistent SaaS connector integration tests
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
Fixing inconsistent SaaS connector integration tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing inconsistencies with the SaaS connector tests for the following connectors:
Changes
filter_resultsthat occurred for row data that is returned from SaaS API responses but not annotated in the datasetchargeandpayment_intent. Cancelled the subscription within Stripe to have consistent data moving forward.Checklist
Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #472