Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up docs (config, css) #615

Merged
merged 4 commits into from
May 9, 2022
Merged

clean up docs (config, css) #615

merged 4 commits into from
May 9, 2022

Conversation

conceptualshark
Copy link
Contributor

@conceptualshark conceptualshark commented May 6, 2022 •
edited by ThomasLaPiana
Loading

Closes #613, #614

Code Changes

  • Remove schemas from mkdocs
  • Remove config.md as now unused
  • Remove config_schemas.json as now unused
  • Remove config_schemas generation from docs generation
  • Fix dark mode css to properly show code block titles

Steps to Confirm

  • nox -s docs_serve runs successfully following changes, schemas is removed from docs pages

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Update CHANGELOG.md

@conceptualshark conceptualshark requested review from a team May 6, 2022 19:08
ThomasLaPiana
ThomasLaPiana approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM!

@ThomasLaPiana ThomasLaPiana merged commit 14d6557 into main May 9, 2022
@ThomasLaPiana ThomasLaPiana deleted the cg-docs-css-update branch May 9, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasLaPiana ThomasLaPiana ThomasLaPiana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Schemas/Config page
2 participants
@conceptualshark @ThomasLaPiana