Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock editing system name for GVL systems #4533

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Lock editing system name for GVL systems #4533

merged 4 commits into from
Jan 2, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Dec 20, 2023 •
edited
Loading

Closes #PROD-1547

Description Of Changes

Disables editing of "System name" field when making changes to a saved GVL system and TCF is enabled.

Loom demo

Steps to Confirm

With Compass and TCF enabled:

  • Go to manual add system form
  • Select a GVL vendor in the "System name" input
  • Form should populate from Compass and notice should appear explaining GVL vendor lock
  • "System name" field should still be editable, but all other fields should be disabled
  • Save the system
  • "System name" field should now be disabled

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 8:30pm

@cypress Cypress
Copy link

cypress bot commented Dec 20, 2023 •
edited
Loading

Passing run #5815 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 390292d into 7f206d3...
Project: fides Commit: deac32a722 ℹ️
Status: Passed Duration: 00:34 💡
Started: Jan 2, 2024 8:38 PM Ended: Jan 2, 2024 8:39 PM

Review all test suite changes for PR #4533 ↗︎

Kelsey-Ethyca
Kelsey-Ethyca approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ You cannot change the system name after save

Screen.Recording.2024-01-02.at.11.05.18.AM.mov

@jpople jpople merged commit 54a6703 into main Jan 2, 2024
13 checks passed
@jpople jpople deleted the jpople/prod-1547/lock-name-on-edit branch January 2, 2024 21:43
NevilleS pushed a commit that referenced this pull request Jan 2, 2024
@jpople @NevilleS
Lock editing system name for GVL systems (#4533)
51a287c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kelsey-Ethyca Kelsey-Ethyca Kelsey-Ethyca approved these changes

@allisonking allisonking Awaiting requested review from allisonking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpople @Kelsey-Ethyca