Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-1484 update frontend for new API res/req for notices served / preferences saved #4518

Merged

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Dec 14, 2023

Closes https://ethyca.atlassian.net/browse/PROD-1484

Description Of Changes

Update frontend for new API res/req for notices served / preferences saved. This needs to be tested and merged alongside #4481

See https://ethyca.atlassian.net/wiki/spaces/EN/pages/2857599071/2023-12-05+Privacy+Preference+Save+API+Changes#Response.2 for description of all changes needed on FE

Code Changes

  • Update models according to the BE overhaul work
  • Update how we transform data that's needed for creating the save preferences API req body.

Steps to Confirm

Pre-Merge Checklist

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 3:46pm

@eastandwestwind eastandwestwind changed the title update frontend for new API res/req for notices served / preferences saved PROD-1484 update frontend for new API res/req for notices served / preferences saved Dec 14, 2023
Copy link

cypress bot commented Dec 14, 2023

Passing run #5706 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 2cd4286 into d8c0ea8...
Project: fides Commit: 92a951c9a7 ℹ️
Status: Passed Duration: 00:33 💡
Started: Dec 19, 2023 3:57 PM Ended: Dec 19, 2023 3:57 PM

Review all test suite changes for PR #4518 ↗︎

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo nice job with the big overhaul!

@eastandwestwind eastandwestwind merged commit 5363e20 into PROD-1477_privacy_preferences_save_refactor Dec 19, 2023
10 checks passed
@eastandwestwind eastandwestwind deleted the PROD-1484 branch December 19, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants