Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Con 59 mg appsflyer connector #4512

Merged
merged 43 commits into from
Jan 9, 2024
Merged

Con 59 mg appsflyer connector #4512

merged 43 commits into from
Jan 9, 2024

Conversation

MarcGEthyca
Copy link
Contributor

@MarcGEthyca MarcGEthyca commented Dec 12, 2023

Closes #CON-59

Description Of Changes

Adding a new Appsflyer Erasure Connector

Code Changes

  • Added required files for configuration, dataset, fixtures, and testing for this connector
  • This connector also includes an override request

Steps to Confirm

  • You should be able to see the Appsflyer option in the integration drop down from within Fides

Pre-Merge Checklist

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2024 4:54am

Copy link

cypress bot commented Dec 12, 2023

Passing run #5874 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge af9e353 into b24c436...
Project: fides Commit: 9c83faf674 ℹ️
Status: Passed Duration: 00:35 💡
Started: Jan 5, 2024 6:19 PM Ended: Jan 5, 2024 6:20 PM

Review all test suite changes for PR #4512 ↗︎

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (b24c436) 87.06% compared to head (af9e353) 87.04%.

Files Patch % Lines
...ide_implementations/appsflyer_request_overrides.py 56.25% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4512      +/-   ##
==========================================
- Coverage   87.06%   87.04%   -0.02%     
==========================================
  Files         334      335       +1     
  Lines       20554    20578      +24     
  Branches     2651     2653       +2     
==========================================
+ Hits        17896    17913      +17     
- Misses       2186     2193       +7     
  Partials      472      472              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcGEthyca MarcGEthyca self-assigned this Dec 18, 2023
@MarcGEthyca
Copy link
Contributor Author

Tests are all passing, this looks okay to me, hopefully no gremlins got into the code over the holidays =)

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Just a few minor things. I can test this once you add the secrets to 1password, I can't find the entry for AppsFlyer.

@galvana galvana self-requested a review January 9, 2024 04:55
@galvana galvana merged commit 36864f7 into main Jan 9, 2024
13 of 14 checks passed
@galvana galvana deleted the CON-59-mg-appsflyer-connector branch January 9, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants