Basic consent reporting UI #4488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #5553 ↗︎
Details:
Review all test suite changes for PR #4488 ↗︎ |
||||||||||||||||||||
|
@simon-keane This is available for review. |
TheAndrewJackson
approved these changes
Dec 6, 2023
…b.com/ethyca/fides into jpople/prod-1434/consent-reporting-ui
jpople
commented
Dec 7, 2023
| return { | ||
| url: "plus/consent_reporting", | ||
| params, | ||
| responseHandler: "content-type", |
There was a problem hiding this comment.
Error results are JSON objects with a detail field, whereas successful results are just the text of the CSV; this makes Redux parse the result out from either.
jpople
commented
Dec 7, 2023
| "A problem occurred while generating your consent report. Please try again." | ||
| ); | ||
| toast({ status: "error", description: message }); | ||
| } else { |
There was a problem hiding this comment.
The actual download had to be moved out of the slice file to be able to handle errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #PROD-1434
Description Of Changes
Adds a basic consent reporting UI, from which you can download a CSV consent report from within a date range.
Steps to Confirm
First, populate the
privacypreferencehistorytable with some requests (instructions courtesy of Adam):Then, in admin UI:
Pre-Merge Checklist
CHANGELOG.md