-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCF purpose summary modal #4477
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #5484 ↗︎
Details:
Review all test suite changes for PR #4477 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meets all the requirements! I just made a few suggestions so let me know what you think.
Something to keep in mind for future iterations is showing read-only fields in a different style than disabled fields. The style for disabled fields is a bit too grayed out in my opinion. I think the read-only fields should be darker to make them easier to read. Not for this ticket though, just something to think about.
clients/admin-ui/src/features/configure-consent/ConsentManagementModal.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/configure-consent/ConsentManagementModal.tsx
Show resolved
Hide resolved
…entModal.tsx Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Closes PROD-1467
Description Of Changes
This adds a read only modal the consent management table
Code Changes
Steps to Confirm
PROD-1466-tcf-purpose-system-report
branch with TCF enabled and dictionary enabled/consent/configure
Pre-Merge Checklist
CHANGELOG.md