Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCF purpose summary modal #4477

Merged
merged 37 commits into from
Dec 5, 2023
Merged

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Dec 1, 2023

Closes PROD-1467

Description Of Changes

This adds a read only modal the consent management table

Code Changes

  • Add readonly consent management model
  • Add route handler for new system purpose summary route
  • Update api types

Steps to Confirm

  • Run the fidesplus PROD-1466-tcf-purpose-system-report branch with TCF enabled and dictionary enabled
  • Add some systems through the bulk vendor add page
  • go to /consent/configure
  • click on a row
  • make sure that the modal shows up and displays everything in read only.

Screenshot from 2023-12-01 17-16-54

Pre-Merge Checklist

@TheAndrewJackson TheAndrewJackson self-assigned this Dec 1, 2023
Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 5:02pm

Copy link

cypress bot commented Dec 1, 2023

Passing run #5484 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 48a092b into b9a1087...
Project: fides Commit: 6956987f4b ℹ️
Status: Passed Duration: 00:33 💡
Started: Dec 5, 2023 5:11 PM Ended: Dec 5, 2023 5:11 PM

Review all test suite changes for PR #4477 ↗︎

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review December 1, 2023 22:11
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meets all the requirements! I just made a few suggestions so let me know what you think.

Something to keep in mind for future iterations is showing read-only fields in a different style than disabled fields. The style for disabled fields is a bit too grayed out in my opinion. I think the read-only fields should be darker to make them easier to read. Not for this ticket though, just something to think about.

…entModal.tsx

Co-authored-by: Adrian Galvan <adrian@ethyca.com>
@TheAndrewJackson TheAndrewJackson merged commit 5dab33f into main Dec 5, 2023
13 checks passed
@TheAndrewJackson TheAndrewJackson deleted the ajackson/PROD-1467/TCF_purpose_modal branch December 5, 2023 17:17
@TheAndrewJackson TheAndrewJackson restored the ajackson/PROD-1467/TCF_purpose_modal branch December 5, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants