consent overlay - rearrange buttons and update spacing #4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Kelsey-Ethyca
changed the title
Passing run #5092 ↗︎
Details:
Review all test suite changes for PR #4391 ↗︎ |
||||||||||||||||||||
allisonking
reviewed
Nov 7, 2023
allisonking
reviewed
Nov 7, 2023
allisonking
reviewed
Nov 7, 2023
| /* Responsive overlay */ | ||
| @media (max-width: 48em) { | ||
| @media (max-width: 768px) { |
There was a problem hiding this comment.
I'd prefer to keep this as em—I took this from chakra
allisonking
approved these changes
Nov 7, 2023
allisonking
reviewed
Nov 7, 2023
allisonking
reviewed
Nov 7, 2023
Comment on lines
+56
to
+59
| --12px: 0.75rem; | ||
| --14px: 0.875rem; | ||
| --15px: 0.9375rem; | ||
| --16px: 1rem; |
There was a problem hiding this comment.
allisonking
reviewed
Nov 7, 2023
Kelsey-Ethyca
added a commit
that referenced
this pull request
Nov 7, 2023
Co-authored-by: Allison King <allisonjuliaking@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-1320
Description Of Changes
This is to clean up some css regressions on the TCF and non-TCF banner and modal so they match the designs https://www.figma.com/file/dmEwdK3xZwjKfGVQ9t66xe/Fides-v.2-Master-Working-Files?node-id=11631%3A46848&mode=dev.
Code Changes
window.Fides.options.tcfEnabledand addisTCFprop toConsentBannnercomponent to avoid potential issues in futureSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdUAT
https://www.loom.com/share/7ced283342a5484aafacb9e73d5e310e?sid=92f842bd-9b0b-44e3-a9d9-5972826829c0