Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-1305 adds fides_disable_banner config option, fix bug with triggering fidesUIShown event for fidesEmbed mode #4378

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

eastandwestwind
Copy link
Contributor

Closes https://ethyca.atlassian.net/browse/PROD-1305

Description Of Changes

Adds fides_disable_banner config option, and as part of this, fixes bug where fidesUIShown event was not triggered for fidesEmbed mode.

Code Changes

  • Adds fides_disable_banner to config options through init, as well as through all 3 override options: cookie, window obj, and query param

Steps to Confirm

  • Add fides_disable_banner as query param on a site that should show the fides banner
  • Confirm banner is not shown, but that the "manage consent preferences" link still works to open the consent modal

Pre-Merge Checklist

Copy link

cypress bot commented Nov 2, 2023

Passing run #4989 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 3507378 into 775e582...
Project: fides Commit: c8ba7c6b80 ℹ️
Status: Passed Duration: 00:31 💡
Started: Nov 2, 2023 11:33 PM Ended: Nov 2, 2023 11:33 PM

Review all test suite changes for PR #4378 ↗︎

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and it works well!

@eastandwestwind eastandwestwind merged commit 45ea329 into main Nov 6, 2023
11 checks passed
@eastandwestwind eastandwestwind deleted the PROD-1305 branch November 6, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants