String override initialization bug #4368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #4923 ↗︎
Details:
Review all test suite changes for PR #4368 ↗︎ |
||||||||||||||||||||
eastandwestwind
approved these changes
Oct 31, 2023
| @@ -1934,6 +1937,46 @@ describe("Fides-js TCF", () => { | |||
| expect(tcData.vendor.legitimateInterests).to.eql({}); | |||
| }); | |||
| }); | |||
| it("can use a fides_string to override a vendor consent", () => { | |||
allisonking
deleted the
aking/prod-1295/string-override-initialization-bug
branch
Kelsey-Ethyca
pushed a commit
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-1295
Description Of Changes
There was a bug where vendor IDs weren't being parsed from the
fides_stringto the cookie properly. The cookie expects these IDs to be prefixed bygvl(since all TCF vendors in the experience will be prefixed bygvl, and that allowsupdateExperienceFromCookieConsentto work properly) but the TC string has no concept of our prefixed IDs.https://www.loom.com/share/81339746560b4f7cbae7200fd1e6470e?sid=9fc5ad92-130b-4886-8ce5-e1f3718793d3
Code Changes
gvlprefix when decoding from TC string to cookiegvl.2instead of2now that our backend has been changed to always sendgvlprefixed IDsSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md