Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use backend GVL json #4159

Merged
merged 7 commits into from
Sep 26, 2023
Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Sep 25, 2023

Closes #3941

Description Of Changes

Removes the FE gvl.json in favor of getting it from the backend.

Code Changes

  • Update types so that privacy experience has an optional gvl type
  • Rework references to the static gvl.json file
  • Lower TCF warning/error kb in rollup config
  • Add the include_gvl param to the fetchExperience calls. This should be okay to always include in fides-js since the backend won't include GVL if there's no TCF to begin with
  • Update cypress tests to include a minimal gvl set to get tests working. Minimal to keep the fixture lean, but we could consider including the whole thing...

Steps to Confirm

  • Everything should work as well as before! In particular, make sure stacks render, and that the GVL tags render

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Sep 25, 2023

Passing run #4332 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 18a9c2c into 9de1d32...
Project: fides Commit: af56dccdfa ℹ️
Status: Passed Duration: 00:58 💡
Started: Sep 25, 2023 8:59 PM Ended: Sep 25, 2023 9:00 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review September 25, 2023 18:27
clients/fides-js/rollup.config.mjs Show resolved Hide resolved
clients/fides-js/src/lib/tcf.ts Outdated Show resolved Hide resolved
clients/fides-js/src/lib/consent-types.ts Show resolved Hide resolved
clients/fides-js/src/lib/tcf.ts Outdated Show resolved Hide resolved
@allisonking allisonking merged commit da6d54d into fidesplus1109_gvl Sep 26, 2023
8 checks passed
@allisonking allisonking deleted the aking/3941/backend-gvl-json branch September 26, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants