Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fides: Relax Legal Basis for Transfers #4049

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Fides: Relax Legal Basis for Transfers #4049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed50e67
Temporary fideslang commit until we release 1.4.6. This allows us to…
pattisdr Sep 8, 2023
3ed4dcf
Bump fideslang to newly-released 1.4.6 and expect "Supplementary meas…
pattisdr Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ The types of changes are:

- Added new Performance-related nox commands and included them as part of the CI suite [#3997](https://github.com/ethyca/fides/pull/3997)
- Added dictionary suggestions for data uses [4035](https://github.com/ethyca/fides/pull/4035)
- Relax system legal basis for transfers to be any string [#4049](https://github.com/ethyca/fides/pull/4049)

## [2.19.0](https://github.com/ethyca/fides/compare/2.18.0...2.19.0)

Expand Down
5 changes: 5 additions & 0 deletions clients/admin-ui/src/features/system/SystemInformationFormSelectOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,16 @@ export const legalBasisForProfilingOptions = [
label: opt,
}));

// Backend technically allows any string
export const legalBasisForTransferOptions = [
{
value: "Adequacy Decision",
label: "Adequacy decision",
},
{
value: "Supplementary measures",
label: "Supplementary measures",
adamsachs marked this conversation as resolved.
Show resolved Hide resolved
},
{
value: "SCCs",
label: "Standard contractual clauses",
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ expandvars==0.9.0
fastapi[all]==0.89.1
fastapi-caching[redis]==0.3.0
fastapi-pagination[sqlalchemy]==0.11.4
fideslang==1.4.5
fideslang==1.4.6
fideslog==1.2.10
firebase-admin==5.3.0
GitPython==3.1.35
Expand Down
14 changes: 12 additions & 2 deletions tests/ctl/core/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,7 +1061,12 @@ def system_update_request_body_with_new_dictionary_fields(
uses_profiling=True,
legal_basis_for_profiling=["Authorised by law", "Contract"],
does_international_transfers=True,
legal_basis_for_transfers=["Adequacy Decision", "BCRs"],
legal_basis_for_transfers=[
"Adequacy Decision",
"BCRs",
"Supplementary Measures",
"Unknown legal basis",
],
requires_data_protection_assessments=True,
dpa_location="https://www.example.com/dpa",
dpa_progress="pending",
Expand Down Expand Up @@ -1491,7 +1496,12 @@ def test_system_update_dictionary_fields(
assert system.uses_profiling is True
assert system.legal_basis_for_profiling == ["Authorised by law", "Contract"]
assert system.does_international_transfers is True
assert system.legal_basis_for_transfers == ["Adequacy Decision", "BCRs"]
assert system.legal_basis_for_transfers == [
"Adequacy Decision",
"BCRs",
"Supplementary Measures",
"Unknown legal basis",
]
assert system.requires_data_protection_assessments is True
assert system.dpa_location == "https://www.example.com/dpa"
assert system.dpa_progress == "pending"
Expand Down
Loading