Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prod 1041/dictionary data uses #4035

Merged
merged 20 commits into from
Sep 7, 2023
Merged

Prod 1041/dictionary data uses #4035

merged 20 commits into from
Sep 7, 2023

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Sep 6, 2023

Description Of Changes

Adds UI for populating data uses on a system using the dictionary.

Note: dictionary suggestions require Fideslang 2.0 to be guaranteed to work, some keys have changed and the backend won't accept them if you're using the old ones. See here for more context.

Screenshot 2023-09-06 at 5 44 12 PM
Screenshot 2023-09-06 at 5 44 27 PM
Screenshot 2023-09-06 at 5 44 45 PM
Screenshot 2023-09-06 at 5 44 50 PM

Steps to Confirm

  • Add a new system
  • Save new system
  • Go to "data uses" tab-- dictionary button should be greyed out, and on hover, a tooltip should show
  • Assign a vendor to the system in "system information" tab
  • Generate dictionary suggestions with "generate data uses automatically" button
  • Accept suggestions

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Sep 6, 2023

Passing run #3981 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 40e6101 into 5989b5f...
Project: fides Commit: 2472ba41e7 ℹ️
Status: Passed Duration: 01:13 💡
Started: Sep 7, 2023 5:59 PM Ended: Sep 7, 2023 6:01 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jpople jpople marked this pull request as ready for review September 7, 2023 14:45
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@jpople jpople merged commit 0e93f5a into main Sep 7, 2023
11 checks passed
@jpople jpople deleted the prod-1041/dictionary-data-uses branch September 7, 2023 18:35
jpople added a commit that referenced this pull request Sep 7, 2023
Co-authored-by: Kelsey Thomas <101993653+Kelsey-Ethyca@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants