Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forcing focus on integration search input #3917

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Forcing focus on integration search input #3917

merged 4 commits into from
Aug 11, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Aug 11, 2023 •
edited
Loading

Closes #3681

Description Of Changes

Keeping a reference to the integration search input so that the focus can be restored after a re-render.

Steps to Confirm

  • Navigate to the system integration tab and search for an integration, you should be able to type more than 2 characters and still keep focus on the input

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@galvana galvana linked an issue Aug 11, 2023 that may be closed by this pull request
Bug: Integration search focus jumps after two chars have been entered. #3681
Closed
TheAndrewJackson
TheAndrewJackson reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once all the CI checks are passing it should be good to go 👍

.../admin-ui/src/features/datastore-connections/system_portal_config/ConnectionListDropdown.tsx Outdated Show resolved Hide resolved
.../admin-ui/src/features/datastore-connections/system_portal_config/ConnectionListDropdown.tsx Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Aug 11, 2023 •
edited
Loading

Passing run #3538 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge c047850 into 385bbec...
Project: fides Commit: 24af7b2d02 ℹ️
Status: Passed Duration: 01:17 💡
Started: Aug 11, 2023 9:02 PM Ended: Aug 11, 2023 9:03 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@galvana galvana merged commit b218f3f into main Aug 11, 2023
9 checks passed
@galvana galvana deleted the 3681-integration-search-focus branch August 11, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAndrewJackson TheAndrewJackson TheAndrewJackson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Integration search focus jumps after two chars have been entered.
2 participants
@galvana @TheAndrewJackson