Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce verbosity of privacy center logging further #3915

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Reduce verbosity of privacy center logging further #3915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3af1b88
Reduce verbosity of privacy center logging further
NevilleS Aug 11, 2023
5f485f7
Fix lint rule
NevilleS Aug 11, 2023
9d5f017
Update CHANGELOG
NevilleS Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ The types of changes are:
### Fixed
- Fixed issue when generating masked values for invalid data paths (#3906)[https://github.com/ethyca/fides/pull/3906]
- Code reload now works when running `nox -s dev` (#3914)[https://github.com/ethyca/fides/pull/3914]
- Reduce verbosity of privacy center logging further (#3915)[https://github.com/ethyca/fides/pull/3915]

## [2.18.0](https://github.com/ethyca/fides/compare/2.17.0...2.18.0)

Expand Down
10 changes: 6 additions & 4 deletions clients/privacy-center/pages/api/fides-js.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable no-console */
import { promises as fsPromises } from "fs";
import type { NextApiRequest, NextApiResponse } from "next";
import { CacheControl, stringify } from "cache-control-parser";
Expand Down Expand Up @@ -88,9 +87,12 @@ export default async function handler(
};
const fidesConfigJSON = JSON.stringify(fidesConfig);

console.log(
"Bundling generic fides.js & Privacy Center configuration together..."
);
if (process.env.NODE_ENV === "development") {
eastandwestwind marked this conversation as resolved.
Show resolved Hide resolved
// eslint-disable-next-line no-console
console.log(
"Bundling generic fides.js & Privacy Center configuration together..."
);
}
const fidesJSBuffer = await fsPromises.readFile("public/lib/fides.js");
const fidesJS: string = fidesJSBuffer.toString();
if (!fidesJS || fidesJS === "") {
Expand Down