Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual system selection #3865

Merged
merged 5 commits into from
Jul 28, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Jul 26, 2023

Closes #3774

Description Of Changes

Removes the manual selection screen. Clicking the Add a system button will now bring you directly to the system creation form.

new_flow.mov

Code Changes

  • Remove the system selection screen
  • Update tests to handle removed screen

Steps to Confirm

  • run fides nox -s dev and the admin UI turbo run dev
  • Go to the add systems page and click the add system button
  • It should bring you straight to the form

Pre-Merge Checklist

@TheAndrewJackson TheAndrewJackson self-assigned this Jul 26, 2023
@cypress
Copy link

cypress bot commented Jul 26, 2023

Passing run #3368 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge cfd5d7b into 6e1b4dd...
Project: fides Commit: 62becee974 ℹ️
Status: Passed Duration: 01:02 💡
Started: Jul 27, 2023 7:17 PM Ended: Jul 27, 2023 7:18 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson changed the title remove manual system selection Remove manual system selection Jul 27, 2023
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review July 27, 2023 19:19
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, love seeing chunks of red. goodbye code! 👋

@TheAndrewJackson TheAndrewJackson merged commit f6eedab into main Jul 28, 2023
10 checks passed
@TheAndrewJackson TheAndrewJackson deleted the ajackson/3774_remove_manual_system_selection branch July 28, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the /add-systems/manual system selector screen
2 participants