Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating directory structure for DSR report #3848

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jul 21, 2023

Closes #3821

Description Of Changes

Updated DSR package structure, the root directory now contains a more user-friendly welcome.html and all of the data necessary to display the report has been aggregated under the data directory.

image

Code Changes

  • Updated file references within the report builder and report templates to reflect the new structure

Steps to Confirm

  • Run nox -s "fides_env(test)"
  • Navigate to the Privacy Center and submit an access request for jane@example.com
  • Navigate to the Admin UI and approve the access request
  • The new DSR package should be available in the fides_uploads directory within your local Fides repo

Pre-Merge Checklist

@galvana galvana linked an issue Jul 21, 2023 that may be closed by this pull request
@cypress
Copy link

cypress bot commented Jul 21, 2023

Passing run #3273 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 0e5568d into 639e267...
Project: fides Commit: 29eae76d8f ℹ️
Status: Passed Duration: 00:45 💡
Started: Jul 21, 2023 11:18 PM Ended: Jul 21, 2023 11:18 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +21.86 🎉

Comparison is base (639e267) 65.31% compared to head (0e5568d) 87.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3848       +/-   ##
===========================================
+ Coverage   65.31%   87.18%   +21.86%     
===========================================
  Files         317      317               
  Lines       19350    19350               
  Branches     2485     2485               
===========================================
+ Hits        12639    16870     +4231     
+ Misses       6260     2049     -4211     
+ Partials      451      431       -20     
Impacted Files Coverage Δ
.../privacy_request/dsr_package/dsr_report_builder.py 94.93% <100.00%> (+63.29%) ⬆️

... and 148 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galvana galvana merged commit 6a446d1 into main Jul 24, 2023
10 of 11 checks passed
@galvana galvana deleted the 3821-update-access-package branch July 24, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update access package organization to match sales feedback
2 participants