Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alphabetize system cards in "view systems" page #3781

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Alphabetize system cards in "view systems" page #3781

merged 4 commits into from
Jul 13, 2023

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jul 13, 2023

Closes #3711

Description Of Changes

System cards are now deterministically alphabetized by name on the "view systems" page.

Code Changes

Changes the getAllSystems query to return an alphabetized list.

Steps to Confirm

  • view "view systems" page with more than one system on it

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Jul 13, 2023 •
edited
Loading

Passing run #3156 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 5b6a2e2 into 10cebca...
Project: fides Commit: df607a1dd8 ℹ️
Status: Passed Duration: 01:12 💡
Started: Jul 13, 2023 3:28 PM Ended: Jul 13, 2023 3:30 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jpople jpople requested a review from allisonking July 13, 2023 15:34
allisonking
allisonking approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jpople jpople merged commit 49fe64c into main Jul 13, 2023
10 checks passed
@jpople jpople deleted the 3711-alphabetical-systems branch July 13, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make list of systems in View Systems deterministic and sorted by alphabetical descending
2 participants
@jpople @allisonking