Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating and editing manual integrations #3772

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Jul 11, 2023

Closes #3752

Description Of Changes

Adds the integration identifier form to the manual connector creation process. The DSR customize form can only be filled out if there is a connection config. The Customize DSR button is disabled with a helpful on hover tooltip that explains that the integration needs to be created first. Once it's created the button will become enabled.

manual_connector.mov

Code Changes

  • Display integration identifier form for manual integrations
  • Disable Customize DSR button until an integration has been created

Steps to Confirm

  • Run fides nox -s dev && turbo run dev
  • Login into fides admin ui and create a system
  • then try to create a manual integration
    • First create the integration
    • When saved click the Customized DSR button and add some DSR fields

Pre-Merge Checklist

@TheAndrewJackson TheAndrewJackson changed the title Ajackson 3752 save manual integration Save and create manual integrations Jul 11, 2023
@TheAndrewJackson TheAndrewJackson changed the title Save and create manual integrations Fix creating and editing manual integrations Jul 11, 2023
@cypress
Copy link

cypress bot commented Jul 11, 2023

Passing run #3125 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge ab094b1 into 956745d...
Project: fides Commit: 610080ac09 ℹ️
Status: Passed Duration: 00:47 💡
Started: Jul 11, 2023 2:39 PM Ended: Jul 11, 2023 2:40 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson self-assigned this Jul 11, 2023
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review July 11, 2023 14:24
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@TheAndrewJackson TheAndrewJackson merged commit fcc9f3e into main Jul 11, 2023
10 checks passed
@TheAndrewJackson TheAndrewJackson deleted the ajackson_3752_save_manual_integration branch July 11, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not save a manual process integration
2 participants