make malicious url test more robust to env differences

[adamsachs]

Closes #3736

Description Of Changes

Mock the admin UI response for our test case to get a more predictable value.

It's not ideal, since there's a slight chance this could lead to false positives in the test case if we adjust our code around this area, so we'll just need to be a bit careful there. But I think it's a good enough test for now - and certainly better than getting false negatives all the time!

Code Changes

• Mock the get_admin_index_as_response function for our test_malicious_url test case to get a more predictable value to evaluate in the test

Steps to Confirm

• just need to make sure CI passes really

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated

[cypress]

Passing run #3083 ↗︎

0

4

0

0

0

Details:

Merge 6e8a11d into bf0efa2...
Project: fides	Commit: 4d48f61dca ℹ️
Status: Passed	Duration: 00:46 💡
Started: Jul 7, 2023 4:42 PM	Ended: Jul 7, 2023 4:43 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[SteveDMurphy]

Thanks for tackling this @adamsachs ! The check failures are a surprise, mypy passes locally for me and the rest look like codecov upload problems. Not sure if we wanted to retry or what

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +21.92 🎉

Comparison is base (bf0efa2) 65.20% compared to head (6e8a11d) 87.12%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3748       +/-   ##
===========================================
+ Coverage   65.20%   87.12%   +21.92%     
===========================================
  Files         311      311               
  Lines       19069    19069               
  Branches     2462     2462               
===========================================
+ Hits        12434    16614     +4180     
+ Misses       6197     2027     -4170     
+ Partials      438      428       -10     

see 147 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[adamsachs]

Thanks for tackling this @adamsachs ! The check failures are a surprise, mypy passes locally for me and the rest look like codecov upload problems. Not sure if we wanted to retry or what

thanks @SteveDMurphy, the mypy issue is this other fun issue that we're already working on, nothing caused by this PR 👍