ignore type checker on click decorators to bypass known library issue

[adamsachs]

Closes #3745

Description Of Changes

Ignore type checker on problematic function calls with decorator wrappers. This is due to a change in click version 8.1.4 that many others are also hitting: pallets/click#2558

See issue descriptions (ours and theirs) for more detail/context.

Follow up tech debt ticket to revert this eventually, when possible: #3749

Code Changes

• add comment to ignore type checker on problematic function calls

Steps to Confirm

• mypy static check passes in CI

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated

[cypress]

Passing run #3086 ↗︎

0

4

0

0

0

Details:

Merge a620ebb into 962905f...
Project: fides	Commit: 42a4ffe927 ℹ️
Status: Passed	Duration: 00:47 💡
Started: Jul 7, 2023 9:43 PM	Ended: Jul 7, 2023 9:43 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[adamsachs]

CI test failures here are a known issue and unrelated, see #3736

[NevilleS]

Is there a way to just ignore all typing error from a library in the pyproject.toml?

For example I think this works to ignore a bunch of mypy failures for all our tests: https://github.com/ethyca/fides/blob/main/pyproject.toml#L30

[adamsachs]

Is there a way to just ignore all typing error from a library in the pyproject.toml?

For example I think this works to ignore a bunch of mypy failures for all our tests: https://github.com/ethyca/fides/blob/main/pyproject.toml#L30

hmm, i think there should be in theory -- i'd expect it to look like this:

[[tool.mypy.overrides]]
module = ["click.*"]
ignore_errors=true

but that's not working when i add it. as a sanity check, when i added this

[[tool.mypy.overrides]]
module = ["fides.cli.options"]
ignore_errors=true

mypy did stop complaining, as expected.

i can keep on digging on it, my guess is that the error's really coming from our module, so it's not effective to ignore errors from the 3rd party lib. we'd have to disable all type checking against that 3rd party lib?

even if i can find a different way to do that, it feels a bit heavy-handed to me, i'd prefer not to ignore all type checking against that library, if possible? although it'd likely be an easier change to revert if/when the underlying problem is fixed 😄

[galvana]

Maybe not be as pretty as we'd like but it works. It avoids side-effects that come with more general error suppression or version pinning. Let's go!