Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Privacy Action Cards to Grow #3669

Merged
merged 4 commits into from
Jun 30, 2023
Merged

Allow Privacy Action Cards to Grow #3669

merged 4 commits into from
Jun 30, 2023

Conversation

RobertKeyser
Copy link
Contributor

@RobertKeyser RobertKeyser commented Jun 23, 2023

Closes #3668

Description Of Changes

This PR changes the privacy center, allowing the privacy action cards to grow if there is a long description (now unlimited lines) or a title that spans two lines. Before, they were static and would lead to clipping and truncation.

Code Changes

  • Replace the h property on the flex element with minH
  • Remove max noOfLines on chakra text element

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Default text, everything should look the same
image

Long descriptions should now truncate at 5 lines instead of 3, grows flexbox
image

Title that spans two lines now grows flexbox
image

Pre-Merge Checklist

@RobertKeyser
Copy link
Contributor Author

Hypothetically speaking, if we wanted to eliminate the limit altogether, we could remove the noOfLines prop on the Text element, which would enable the following monstrosity:

image

There are a few approaches here:

  1. We let the user do whatever they want and have the box grow to an infinite length.
  2. We impose a limit for the sake of prescriptive usability.

@RobertKeyser RobertKeyser self-assigned this Jun 23, 2023
@cypress
Copy link

cypress bot commented Jun 23, 2023

Passing run #2898 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge ed38a02 into c55abb0...
Project: fides Commit: 3b8a09dc03 ℹ️
Status: Passed Duration: 00:45 💡
Started: Jun 23, 2023 7:15 PM Ended: Jun 23, 2023 7:16 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@RobertKeyser RobertKeyser merged commit c169bc5 into main Jun 30, 2023
9 checks passed
@RobertKeyser RobertKeyser deleted the 3668-cards-grow branch June 30, 2023 14:36
@SteveDMurphy SteveDMurphy mentioned this pull request Jun 30, 2023
10 tasks
SteveDMurphy pushed a commit that referenced this pull request Jul 1, 2023
SteveDMurphy pushed a commit that referenced this pull request Jul 1, 2023
@SteveDMurphy SteveDMurphy mentioned this pull request Jul 5, 2023
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Privacy Center - Long Action Titles Lead to Cutoff Description Text
3 participants