Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe to individual system query in manual create #3662

Merged
merged 4 commits into from
Jun 23, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jun 22, 2023

Closes #3661

Code Changes

  • Add a redux subscription + useEffect similar to what exists in the [id].tsx page but in the SystemFormTabs component so that activeSystem stays up to date in the new system flow, too

Steps to Confirm

  • See ticket

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Description Of Changes

just realized the buttons don't look great in a smaller viewport, but that's unrelated to this work

Screen.Recording.2023-06-22.at.6.20.38.PM.mov

@cypress
Copy link

cypress bot commented Jun 22, 2023

Passing run #2882 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge ed85099 into b4f1b3b...
Project: fides Commit: 03b95538c7 ℹ️
Status: Passed Duration: 01:12 💡
Started: Jun 23, 2023 4:12 PM Ended: Jun 23, 2023 4:13 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

SystemFormTabs will handle this now
Redux invalidates the cache resulting in a new call to get the updated system. Cypress tests were skirting by but now we need to be more strict about their intercepts
@allisonking allisonking marked this pull request as ready for review June 23, 2023 16:17
@allisonking allisonking merged commit df2d243 into main Jun 23, 2023
@allisonking allisonking deleted the aking/3661/system-route branch June 23, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release bug: not handling dedicated system routes right
2 participants