Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the sample app privacy center link to be configurable #3409

Merged
merged 2 commits into from
May 31, 2023
Merged

Fix the sample app privacy center link to be configurable #3409

merged 2 commits into from
May 31, 2023

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented May 31, 2023 •
edited
Loading

Code Changes

  • Use the FIDES_SAMPLE_APP__PRIVACY_CENTER_URL for the sample app footer link

Steps to Confirm

  • Run nox -s "fides_env(test)" and ensure the link still works!

Pre-Merge Checklist

Description Of Changes

Tiny polish fix for the Cookie House link!

@NevilleS NevilleS merged commit 5fbd71d into main May 31, 2023
@NevilleS NevilleS deleted the ns-fix-sample-app-privacy-center-link branch May 31, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertKeyser RobertKeyser RobertKeyser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NevilleS @RobertKeyser