Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin typing_extensions to version 4.5.0 #3357

Merged
merged 4 commits into from
May 23, 2023

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented May 23, 2023

Closes #3358

Workaround for pydantic/pydantic#5821

Code Changes

Steps to Confirm

  • CI jobs for python < 3.10 should pass
  • server should boot successfully in a python 3.9 or 3.8 environment
  • app should run as normal (i.e., no regressions)

Pre-Merge Checklist

Description Of Changes

Caused by pydantic/pydantic#5821. Our backend-check CI jobs that run on python < 3.10 were failing.

@adamsachs adamsachs changed the title pin typing_extensions to version 4.5.0 to bypass pydantic bug with Li… pin typing_extensions to version 4.5.0 May 23, 2023
@adamsachs adamsachs changed the title pin typing_extensions to version 4.5.0 pin typing_extensions to version 4.5.0 May 23, 2023
@cypress
Copy link

cypress bot commented May 23, 2023

Passing run #2125 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 7151765 into 52bcd75...
Project: fides Commit: 7e5529f8a6 ℹ️
Status: Passed Duration: 00:47 💡
Started: May 23, 2023 4:04 PM Ended: May 23, 2023 4:05 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@adamsachs adamsachs marked this pull request as ready for review May 23, 2023 15:29
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (52bcd75) 87.07% compared to head (7151765) 87.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3357   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files         313      313           
  Lines       18997    18997           
  Branches     2474     2474           
=======================================
  Hits        16541    16541           
  Misses       2014     2014           
  Partials      442      442           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM, thanks!

Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM, thanks!

@adamsachs adamsachs merged commit 04373ba into main May 23, 2023
@adamsachs adamsachs deleted the pin-typing-extensions-version-pydantic-5821 branch May 23, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with python < 3.10 caused by pydantic bug
3 participants