Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3271 data categories for manual connectors #3330

Merged
merged 7 commits into from
May 22, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented May 18, 2023

Closes #3270 #3271

Code Changes

  • Updated CustomSelect component to only display the label Text component if a label is provided
  • Updated the DSRCustomizationForm component to include an optional Data Categories column
  • Added data_categories field to ManualWebhookField model
  • Updated existing manual webhook tests

Steps to Confirm

  • Created a new manual webhook connection from the UI with some fields containing data categories and others with no data categories assigned.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
  • Issue Requirements are Met
  • Update CHANGELOG.md

@galvana galvana linked an issue May 18, 2023 that may be closed by this pull request
@TheAndrewJackson
Copy link
Contributor

Everything looks good. Once the conflict is resolved and the additional test case is added I think it'll be ready 👍

@cypress
Copy link

cypress bot commented May 19, 2023

Passing run #2086 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 0caaca2 into d407775...
Project: fides Commit: e0498a687c ℹ️
Status: Passed Duration: 00:48 💡
Started: May 19, 2023 10:01 PM Ended: May 19, 2023 10:02 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (9a26ca1) 87.07% compared to head (0caaca2) 87.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3330      +/-   ##
==========================================
- Coverage   87.07%   87.07%   -0.01%     
==========================================
  Files         313      313              
  Lines       18968    18970       +2     
  Branches     2473     2473              
==========================================
+ Hits        16517    16518       +1     
  Misses       2009     2009              
- Partials      442      443       +1     
Impacted Files Coverage Δ
src/fides/api/schemas/manual_webhook_schemas.py 82.75% <100.00%> (+0.61%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@galvana galvana merged commit 268c4a1 into main May 22, 2023
@galvana galvana deleted the 3271-data-categories-for-manual-connectors branch May 22, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE - Add Data Categories to AccessManualWebhook BE - Add Data Categories to AccessManualWebhook
2 participants