Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy declaration with composite ID #2905

Merged
merged 5 commits into from
Mar 24, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Mar 23, 2023

Closes #2894

Code Changes

  • Uses a new type PrivacyDeclarationWithId to facilitate name and data use comparisons
    • In retrospect, this was a little overkill, as it doesn't actually solve this problem. It gets us a lot closer though—we could probably use a javascript UUID package and replace the ID there and be fairly close. However, I think it'd be better if the backend gave an ID instead 😄
    • The 🔑 thing here was updating the key value to be a composite instead of just based off of data_use
  • Update various logic that used to only compare data uses to also compare names of privacy declarations
  • Update tests

Steps to Confirm

  • Add data uses on a system
  • You should be able to add the same data use as long as the name of it is different. If the name and data use are the same, you'll get an error
  • Also try deleting

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@allisonking allisonking force-pushed the aking/2894/privacy-declaration-with-composite-id branch from 699d3e2 to 435d754 Compare March 23, 2023 19:46
@cypress
Copy link

cypress bot commented Mar 23, 2023

Passing run #970 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 0f3ba2c into dfabd1d...
Project: fides Commit: 3c61ff2b41 ℹ️
Status: Passed Duration: 00:36 💡
Started: Mar 23, 2023 8:43 PM Ended: Mar 23, 2023 8:44 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dfabd1d) 86.60% compared to head (0f3ba2c) 86.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2905   +/-   ##
=======================================
  Coverage   86.60%   86.60%           
=======================================
  Files         299      299           
  Lines       16814    16814           
  Branches     2148     2148           
=======================================
  Hits        14562    14562           
  Misses       1841     1841           
  Partials      411      411           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@allisonking allisonking merged commit 5f901e1 into main Mar 24, 2023
@allisonking allisonking deleted the aking/2894/privacy-declaration-with-composite-id branch March 24, 2023 15:48
Kelsey-Ethyca added a commit that referenced this pull request Mar 24, 2023
Co-authored-by: Kelsey Thomas <101993653+Kelsey-Ethyca@users.noreply.github.com>
Kelsey-Ethyca added a commit that referenced this pull request Mar 24, 2023
Co-authored-by: Kelsey Thomas <101993653+Kelsey-Ethyca@users.noreply.github.com>
Kelsey-Ethyca added a commit that referenced this pull request Mar 24, 2023
Co-authored-by: Kelsey Thomas <101993653+Kelsey-Ethyca@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System data uses update all that share the same Fideslang data use
2 participants