Update Admin UI Layout to fill viewport height #2812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Changes
Layout.tsx
to fill the viewport withnav
,header
, andmain
divsSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
This is a small CSS change to ensure the overall app layout is consistent between the Fides and Fides Plus Admin UIs. In the Plus UI we have some pages that need to fill the viewport height, so the overall Layout needs to include
height=100vh
over there - by doing the same here, it just means we're less likely to get some minor discrepancies in app layouts over time without noticing.Note: this should have no visual effect on the existing app pages! I looked at all of them (home, privacy requests, data map, management) and confirmed this... it might seem like a useless PR but I promise this makes sense 😛