Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pc/consent: Pass GPC status fields to consent update request #2672

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

ssangervasi
Copy link
Contributor

Closes #2232

Code Changes

  • pc/types: Update Consent API model
  • pc/cy: Assert GPC fields passed to API
  • pc/consent: Pass GPC status fields to consent update request

Steps to Confirm

  • Build latest fides so that new fields are in the API + DB
  • Enable GPC in browser or using ?globalPrivacyControl=true query parameter.
  • Override an option that's highlighted for GPC and save -> The value choice should be reflected in the request & DB

Pre-Merge Checklist

@ssangervasi ssangervasi changed the title Ssangervasi/fides/2232/send gpc context to api pc/consent: Pass GPC status fields to consent update request Feb 22, 2023
@cypress
Copy link

cypress bot commented Feb 22, 2023

Passing run #351 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c4aebe0 into 9e71c99...
Project: fides Commit: 3a8aa34ed9 ℹ️
Status: Passed Duration: 00:41 💡
Started: Feb 23, 2023 7:20 PM Ended: Feb 23, 2023 7:21 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 86.47% // Head: 86.39% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (abf4dcf) compared to base (b864d73).
Patch has no changes to coverable lines.

❗ Current head abf4dcf differs from pull request most recent head c4aebe0. Consider uploading reports for the commit c4aebe0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2672      +/-   ##
==========================================
- Coverage   86.47%   86.39%   -0.08%     
==========================================
  Files         289      289              
  Lines       15965    15998      +33     
  Branches     2022     2017       -5     
==========================================
+ Hits        13805    13822      +17     
- Misses       1778     1788      +10     
- Partials      382      388       +6     
Impacted Files Coverage Δ
src/fides/core/config/database_settings.py 83.33% <0.00%> (-16.67%) ⬇️
src/fides/lib/db/session.py 78.57% <0.00%> (-14.29%) ⬇️
src/fides/core/config/__init__.py 89.77% <0.00%> (-5.74%) ⬇️
src/fides/api/ops/schemas/messaging/messaging.py 98.70% <0.00%> (-0.08%) ⬇️
src/fides/core/config/redis_settings.py 82.85% <0.00%> (-0.07%) ⬇️
src/fides/core/config/security_settings.py 98.78% <0.00%> (-0.05%) ⬇️
src/fides/core/user.py 100.00% <0.00%> (ø)
src/fides/api/ops/util/logger.py 100.00% <0.00%> (ø)
src/fides/api/ctl/database/seed.py 100.00% <0.00%> (ø)
src/fides/api/ctl/database/session.py 100.00% <0.00%> (ø)
... and 52 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ssangervasi ssangervasi force-pushed the ssangervasi/fides/2232/send-gpc-context-to-api branch from abf4dcf to c4aebe0 Compare February 23, 2023 19:06
@ssangervasi ssangervasi merged commit 76b9988 into main Feb 23, 2023
@ssangervasi ssangervasi deleted the ssangervasi/fides/2232/send-gpc-context-to-api branch February 23, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record all applications of a Global Privacy Control Signal
2 participants