Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth to all slices #2645

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Add auth to all slices #2645

merged 1 commit into from
Feb 17, 2023

Conversation

allisonking
Copy link
Contributor

#2588 enforces auth on all routes. previously many of our old ctl routes didn't include auth headers. this makes them include them.

Code Changes

  • copy pasta auth headers everywhere

Steps to Confirm

  • Click through the UI and make sure everything is still accessible

Pre-Merge Checklist

Description Of Changes

This is a lot of inelegant copy/pasta-ing, but I can live with it considering we've got this ticket in the pipeline #1386

(once that ticket is in, we'd only need the one prepareHeader

Copy link
Contributor

@ssangervasi ssangervasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪦

@cypress
Copy link

cypress bot commented Feb 17, 2023

Passing run #207 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 5ff58ae into 69ecb30...
Project: fides Commit: 1d41d6c168 ℹ️
Status: Passed Duration: 00:35 💡
Started: Feb 17, 2023 6:50 PM Ended: Feb 17, 2023 6:50 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 86.23% // Head: 86.23% // No change to project coverage 👍

Coverage data is based on head (5ff58ae) compared to base (69ecb30).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2645   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files         289      289           
  Lines       15784    15784           
  Branches     1985     1985           
=======================================
  Hits        13611    13611           
  Misses       1785     1785           
  Partials      388      388           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@allisonking allisonking merged commit ac89777 into main Feb 17, 2023
@allisonking allisonking deleted the aking/fix-ctl-auth branch February 17, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants