Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wunderkind Saas Consent Connector #2600

Merged
merged 5 commits into from
Feb 15, 2023
Merged

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Feb 15, 2023

Closes https://github.com/ethyca/fidesplus/issues/517

Code Changes

  • Adds a new Wunderkind Consent Connector

Steps to Confirm

  • In your test env privacy center, mark Data Sales or Sharing as the consent preference that is executable (the config.json file). Right now only one consent preference that can be persisted to third party services.

  • Run nox -s "fides_env(dev)"

  • Go to the admin ui Add a New Connector and search for Wunderkind - it is a saas connector
    Screen Shot 2023-02-15 at 10 42 43 AM

  • Main required parameter is a website_id - we don't have one of these, so I am just making one up, like test_wunderkind_website_id

Screen Shot 2023-02-15 at 10 41 14 AM

  • In the privacy center, modify a test user's consent preferences ("customer-1@example.com") and opt in or out of data sales or sharing
  • Return to the admin app and approve the associated privacy request
  • Verify that the privacy request completes. Verify execution logs, and that there's a single log for wunderkind
  • Verify the API request made in the logs to wunderkind. Verify you get the correct query parameter depending on whether you opted in or opted out - see "DESCRIPTION OF CHANGES" below

Pre-Merge Checklist

Description Of Changes

Note that consent connectors aren't yet linked to specific data uses. This connector sets a consent value of "1YN" if the user is opting in, and "1YY" if the user is opting out. To link this to Data Sales/Data sharing, the customer should set up their privacy center to have that particular data use be executable.

  • If user has opted out of Data Sales/Data Sharing then "1YY"
  • If user has opted in out of Data Sales/Data Sharing then "1YN"

…alues for the existing opt out request.

If user has opted in out of Data Sales/Data Sharing then "1YN"
If user has opted out of Data Sales/Data Sharing then "1YY"
@pattisdr pattisdr marked this pull request as ready for review February 15, 2023 16:27
@pattisdr pattisdr mentioned this pull request Feb 15, 2023
8 tasks
@pattisdr pattisdr changed the title Wunderkind Consent Connector Wunderkind Saas Consent Connector Feb 15, 2023
@cypress
Copy link

cypress bot commented Feb 15, 2023

Passing run #120 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge 872a770 into 5f533b2...
Project: fides Commit: ba1130968b ℹ️
Status: Passed Duration: 00:53 💡
Started: Feb 15, 2023 6:51 PM Ended: Feb 15, 2023 6:52 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@pattisdr pattisdr added the run unsafe ci checks Runs fideops-related CI checks that require sensitive credentials label Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 85.91% // Head: 85.91% // No change to project coverage 👍

Coverage data is based on head (872a770) compared to base (5f533b2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2600   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files         285      285           
  Lines       15496    15496           
  Branches     1947     1947           
=======================================
  Hits        13314    13314           
  Misses       1799     1799           
  Partials      383      383           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pattisdr pattisdr requested a review from a team February 15, 2023 16:55
@pattisdr
Copy link
Contributor Author

@allisonking do you know why the privacy ceneter cypress test might be failing?

Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the help in review @pattisdr ! Everything looks great, the only other question I had was around some of the documentation that will go around setting some of these items up properly in the config.json - is there a separate issue on the docs repo for that already?

@allisonking
Copy link
Contributor

@allisonking do you know why the privacy ceneter cypress test might be failing?

nope they've been failing for a few days now. sometimes it goes away though... I can never repro locally https://ethyca.slack.com/archives/CBKK8TS74/p1675902294810199

@pattisdr
Copy link
Contributor Author

ok no problem @allisonking thanks for weighing in

@pattisdr
Copy link
Contributor Author

Thank you for the help in review @pattisdr ! Everything looks great, the only other question I had was around some of the documentation that will go around setting some of these items up properly in the config.json - is there a separate issue on the docs repo for that already?

Good question, I have some a draft of docs on the docs site that Sai will polishhttps://github.com/ethyca/fidesdocs/pull/35#issuecomment-1430902122.

This is supposed to be temporary too until we have a proper mapping from data uses -> which requests fire. That's why we currently restrict to one because no mapping exists.

@pattisdr
Copy link
Contributor Author

pattisdr commented Feb 15, 2023

Remaining saas failure is longstanding: test_friendbuy_nextgen_erasure_request_task, as is the ctl-external failure: tests/ctl/core/test_system.py::test_scan_system_aws_passes. Note that these tests aren't usually run and only run here because I added the "run unsafe ci checks". Timescale failure would likely pass on re-run.

@pattisdr
Copy link
Contributor Author

I believe all failing tests are unrelated - merging.

@pattisdr pattisdr merged commit 4bf8330 into main Feb 15, 2023
@pattisdr pattisdr deleted the wunderkind_consent_connector branch February 15, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run unsafe ci checks Runs fideops-related CI checks that require sensitive credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants