-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wunderkind Saas Consent Connector #2600
Conversation
…alues for the existing opt out request. If user has opted in out of Data Sales/Data Sharing then "1YN" If user has opted out of Data Sales/Data Sharing then "1YY"
Passing run #120 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportBase: 85.91% // Head: 85.91% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2600 +/- ##
=======================================
Coverage 85.91% 85.91%
=======================================
Files 285 285
Lines 15496 15496
Branches 1947 1947
=======================================
Hits 13314 13314
Misses 1799 1799
Partials 383 383 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@allisonking do you know why the privacy ceneter cypress test might be failing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the help in review @pattisdr ! Everything looks great, the only other question I had was around some of the documentation that will go around setting some of these items up properly in the config.json
- is there a separate issue on the docs repo for that already?
nope they've been failing for a few days now. sometimes it goes away though... I can never repro locally https://ethyca.slack.com/archives/CBKK8TS74/p1675902294810199 |
ok no problem @allisonking thanks for weighing in |
Good question, I have some a draft of docs on the docs site that Sai will polishhttps://github.com/ethyca/fidesdocs/pull/35#issuecomment-1430902122. This is supposed to be temporary too until we have a proper mapping from data uses -> which requests fire. That's why we currently restrict to one because no mapping exists. |
Remaining saas failure is longstanding: test_friendbuy_nextgen_erasure_request_task, as is the ctl-external failure: tests/ctl/core/test_system.py::test_scan_system_aws_passes. Note that these tests aren't usually run and only run here because I added the "run unsafe ci checks". Timescale failure would likely pass on re-run. |
I believe all failing tests are unrelated - merging. |
Closes https://github.com/ethyca/fidesplus/issues/517
Code Changes
Steps to Confirm
In your test env privacy center, mark Data Sales or Sharing as the consent preference that is executable (the config.json file). Right now only one consent preference that can be persisted to third party services.
Run nox -s "fides_env(dev)"
Go to the admin ui Add a New Connector and search for Wunderkind - it is a saas connector
Main required parameter is a
website_id
- we don't have one of these, so I am just making one up, liketest_wunderkind_website_id
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Note that consent connectors aren't yet linked to specific data uses. This connector sets a consent value of "1YN" if the user is opting in, and "1YY" if the user is opting out. To link this to Data Sales/Data sharing, the customer should set up their privacy center to have that particular data use be executable.