Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Readability for Custom Masking Override Exceptions #2593

Merged

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Feb 14, 2023

Issue: None

Code Changes

  • list your code changes here

Steps to Confirm

  • Re-raise the initial exception encountered by the masking request override

Pre-Merge Checklist

Description Of Changes

Similar to #2157, if there's an issue with a masking override, the error is too vague for troubleshooting.

@cypress
Copy link

cypress bot commented Feb 14, 2023

Passing run #76 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge 28fcead into 9b9a03a...
Project: fides Commit: 89c675fe09 ℹ️
Status: Passed Duration: 00:37 💡
Started: Feb 14, 2023 7:07 PM Ended: Feb 14, 2023 7:08 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@pattisdr pattisdr marked this pull request as ready for review February 14, 2023 19:12
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 85.74% // Head: 85.74% // No change to project coverage 👍

Coverage data is based on head (28fcead) compared to base (9b9a03a).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2593   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files         285      285           
  Lines       15477    15477           
  Branches     1945     1945           
=======================================
  Hits        13270    13270           
  Misses       1832     1832           
  Partials      375      375           
Impacted Files Coverage Δ
...fides/api/ops/service/connectors/saas_connector.py 67.54% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seanpreston seanpreston merged commit eba67f0 into main Feb 14, 2023
@seanpreston seanpreston deleted the update_readability_for_masking_override_exceptions branch February 14, 2023 19:29
@seanpreston seanpreston restored the update_readability_for_masking_override_exceptions branch February 14, 2023 19:48
@NevilleS NevilleS deleted the update_readability_for_masking_override_exceptions branch March 14, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants