-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sovrn cookie to privacy center #2582
Add sovrn cookie to privacy center #2582
Conversation
Passing run #107 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportBase: 88.90% // Head: 86.05% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## fides_2394_sovrn_connector #2582 +/- ##
==============================================================
- Coverage 88.90% 86.05% -2.86%
==============================================================
Files 335 289 -46
Lines 16378 15760 -618
Branches 4548 1983 -2565
==============================================================
- Hits 14561 13562 -999
- Misses 1658 1818 +160
- Partials 159 380 +221
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes here, building on what you already established with the ga client ids!
Part of #2458
Code Changes
inspectForBrowserIdentities
to be able to handle more than one cookie valueSteps to Confirm
document.cookie = "ljt_readerID=fides_test_reader_id;";
ljt_readerID
show up in the payload for PATCH preferences underbrowser_identity
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats