Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sovrn cookie to privacy center #2582

Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Feb 13, 2023

Part of #2458

Code Changes

  • Refactor inspectForBrowserIdentities to be able to handle more than one cookie value
  • Update tests

Steps to Confirm

  • Spin up the privacy center
  • Add a cookie to your browser i.e. document.cookie = "ljt_readerID=fides_test_reader_id;";
  • Change your consent preferences
  • Inspect the network tab, and you should see ljt_readerID show up in the payload for PATCH preferences under browser_identity

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@allisonking allisonking changed the base branch from main to fides_2394_sovrn_connector February 13, 2023 20:25
@cypress
Copy link

cypress bot commented Feb 13, 2023

Passing run #107 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge 5dee01e into e56bfdf...
Project: fides Commit: 101b96f5a5 ℹ️
Status: Passed Duration: 00:38 💡
Started: Feb 15, 2023 3:54 PM Ended: Feb 15, 2023 3:55 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 88.90% // Head: 86.05% // Decreases project coverage by -2.86% ⚠️

Coverage data is based on head (5dee01e) compared to base (892d123).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                      Coverage Diff                       @@
##           fides_2394_sovrn_connector    #2582      +/-   ##
==============================================================
- Coverage                       88.90%   86.05%   -2.86%     
==============================================================
  Files                             335      289      -46     
  Lines                           16378    15760     -618     
  Branches                         4548     1983    -2565     
==============================================================
- Hits                            14561    13562     -999     
- Misses                           1658     1818     +160     
- Partials                          159      380     +221     
Impacted Files Coverage Δ
.../ops/service/messaging/message_dispatch_service.py 46.79% <0.00%> (-28.58%) ⬇️
...ides/api/ops/email_templates/get_email_template.py 62.50% <0.00%> (-18.75%) ⬇️
src/fides/api/ctl/routes/util.py 64.51% <0.00%> (-16.13%) ⬇️
src/fides/api/ops/db/base_class.py 71.42% <0.00%> (-15.24%) ⬇️
src/fides/core/annotate_dataset.py 21.12% <0.00%> (-14.49%) ⬇️
src/fides/api/ops/schemas/api.py 80.00% <0.00%> (-11.67%) ⬇️
src/fides/lib/db/session.py 78.57% <0.00%> (-11.09%) ⬇️
.../fides/api/ops/service/connectors/sql_connector.py 76.14% <0.00%> (-10.64%) ⬇️
.../service/privacy_request/request_runner_service.py 77.06% <0.00%> (-10.20%) ⬇️
src/fides/core/config/notification_settings.py 90.00% <0.00%> (-10.00%) ⬇️
... and 258 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@allisonking allisonking marked this pull request as ready for review February 13, 2023 23:13
@allisonking allisonking mentioned this pull request Feb 14, 2023
13 tasks
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes here, building on what you already established with the ga client ids!

@allisonking allisonking merged commit 0e27ea4 into fides_2394_sovrn_connector Feb 16, 2023
@allisonking allisonking deleted the aking/2458/add-sovrn-cookie-to-pc branch February 16, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants