Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config wizard stepper #2553

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Feb 9, 2023

Closes #2535

Code Changes

  • Removes code associated with the config wizard stepper
  • Removes it from feature flags

Steps to Confirm

  • Should no longer be able to see the stepper as an option in feature flags
  • It should not show up anywhere

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 88.11% // Head: 88.66% // Increases project coverage by +0.54% 🎉

Coverage data is based on head (8ee2720) compared to base (0f0bdbf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2553      +/-   ##
==========================================
+ Coverage   88.11%   88.66%   +0.54%     
==========================================
  Files         331      331              
  Lines       16095    16095              
  Branches     4416     4469      +53     
==========================================
+ Hits        14182    14270      +88     
+ Misses       1756     1668      -88     
  Partials      157      157              
Impacted Files Coverage Δ
src/fides/api/ops/task/graph_task.py 93.52% <0.00%> (+0.97%) ⬆️
src/fides/core/utils.py 82.10% <0.00%> (+1.05%) ⬆️
src/fides/api/ctl/database/crud.py 71.55% <0.00%> (+1.83%) ⬆️
src/fides/api/main.py 86.75% <0.00%> (+1.98%) ⬆️
src/fides/api/ctl/database/database.py 90.27% <0.00%> (+2.77%) ⬆️
src/fides/cli/utils.py 74.15% <0.00%> (+2.80%) ⬆️
src/fides/api/ops/util/saas_util.py 94.28% <0.00%> (+3.57%) ⬆️
src/fides/api/ops/tasks/storage.py 80.00% <0.00%> (+3.75%) ⬆️
.../fides/api/ops/service/connectors/sql_connector.py 86.78% <0.00%> (+5.28%) ⬆️
.../service/privacy_request/request_runner_service.py 86.00% <0.00%> (+7.20%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@allisonking allisonking marked this pull request as ready for review February 9, 2023 19:49
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@allisonking allisonking merged commit e50015c into main Feb 10, 2023
@allisonking allisonking deleted the aking/2535/remove-config-wizard-stepper branch February 10, 2023 16:34
allisonking added a commit that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the config wizard stepper
2 participants